adopt the new classes for plot's big numbers #554
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,7 +26,7 @@ The [`npm-downloads.csv.ts`](./docs/data/npm-downloads.csv.ts) loader retrieves | |
|
|
||
| ## Big numbers | ||
|
|
||
| Key performance indicators are displayed as “big numbers” with, in some cases, a trend indicating growth over one week. Their layout is using the convenience CSS classes _big_, _red_ etc. | ||
|
|
||
| ## Charts | ||
|
|
||
|
|
||
Fil marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -6,7 +6,6 @@ theme: dashboard | |||||||
| # Plot | ||||||||
|
|
||||||||
| ```js | ||||||||
| import {DailyPlot, today, start} from "./components/dailyPlot.js"; | ||||||||
| ``` | ||||||||
|
|
||||||||
|
|
@@ -21,6 +20,9 @@ const stars = FileAttachment("data/plot-github-stars.csv").csv({typed: true}); | |||||||
| const lastMonth = d3.utcDay.offset(today, -28); | ||||||||
| const lastWeek = d3.utcDay.offset(today, -7); | ||||||||
| const x = {domain: [start, today]}; | ||||||||
| function trend(value, format) { | ||||||||
|
There was a problem hiding this comment.
Suggested change
This sort of function should have a default format, or better, allow the format to be optionally specified as a function (and promote to a function when a string). If I wanted it to be reusable, I’d probably also take an options object instead of |
||||||||
| return html`<span class="${value > 0 ? "green" : value < 0 ? "red" : "muted"}">${d3.format(format)(value)} ${value > 0 ? "↗︎" : value < 0 ? "↘︎" : ""}`; | ||||||||
| } | ||||||||
| ``` | ||||||||
|
|
||||||||
| ```js | ||||||||
|
|
@@ -43,17 +45,29 @@ const burndown = issues | |||||||
| ``` | ||||||||
|
|
||||||||
| <div class="grid grid-cols-4" style="grid-auto-rows: 86px;"> | ||||||||
| <div class="card"> | ||||||||
| <h2>Current release</h2> | ||||||||
| <span class="big">${versions.at(-1).version}</span> | ||||||||
| <a href="https://github.com/observablehq/plot/releases" style="color: inherit;"> | ||||||||
| ${((days) => days === 0 ? "today" : days === 1 ? "yesterday" : `${days} days ago`)(d3. utcDay.count(versions.at(-1).date, Date.now()))} | ||||||||
Fil marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||
| </a> | ||||||||
| </div> | ||||||||
| <div class="card"> | ||||||||
| <h2>GitHub stars</h2> | ||||||||
| <span class="big">${d3.format(",")(stars.length)}</span> | ||||||||
| <span class="green">${d3.format("+")(d3.sum(stars, (d) => d.starred_at >= lastWeek))} ↗︎</ span> | ||||||||
Fil marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||
| </div> | ||||||||
| <div class="card"> | ||||||||
| <h2>Daily npm downloads</h2> | ||||||||
| <span class="big">${d3.format(",")(downloads[0].value)}</span> | ||||||||
| ${trend(downloads[7].value | ||||||||
| ? (downloads[0].value - downloads[7].value) / downloads[7].value | ||||||||
| : undefined, d3.format("+.1%"))} | ||||||||
| </div> | ||||||||
| <div class="card"> | ||||||||
| <h2>Total npm downloads</h2> | ||||||||
| <span class="big">${d3.format(",")(d3.sum(downloads, (d) => d.value))} | ||||||||
Fil marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||
| </div> | ||||||||
| </div> | ||||||||
|
|
||||||||
| <div class="card grid grid-cols-1" style="grid-auto-rows: calc(260px + 2rem);"> | ||||||||
|
|
@@ -100,10 +114,22 @@ const burndown = issues | |||||||
| </div> | ||||||||
|
|
||||||||
| <div class="grid grid-cols-4" style="grid-auto-rows: 86px;"> | ||||||||
| <div class="card"> | ||||||||
| <h2>Open issues</h2> | ||||||||
| <a href="https://github.com/observablehq/plot/issues" class="big" style="color: inherit;">${d3.format(",")(d3.sum(issues, (d) => !d.pull_request && d.state === "open"))}</a> | ||||||||
| </div> | ||||||||
| <div class="card"> | ||||||||
| <h2>Opened issues, 28d</h2> | ||||||||
| <span class="big">${d3.format(",")(d3.sum(issues, (d) => !d.pull_request && d.open >= lastMonth))}</span> | ||||||||
|
There was a problem hiding this comment. I’m not a big fan of the |
||||||||
| </div> | ||||||||
| <div class="card"> | ||||||||
| <h2>Closed issues, 28d</h2> | ||||||||
| <span class="big">${d3.format(",")(d3.sum(issues, (d) => !d.pull_request && d.close >= lastMonth))}</span> | ||||||||
| </div> | ||||||||
| <div class="card"> | ||||||||
| <h2>Open PRs</h2> | ||||||||
| <a class="big" href="https://github.com/observablehq/plot/pulls?q=is%3Apr+is%3Aopen+draft%3Afalse" style="color: inherit;">${d3.format(",")(d3.sum(issues, (d) => d.pull_request && d.state === "open" && !d.draft))}</a> | ||||||||
| </div> | ||||||||
| </div> | ||||||||
|
|
||||||||
| <div class="grid grid-cols-2" style="grid-auto-rows: 276px;"> | ||||||||
|
|
||||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this has too much complexity to be practical. We need to find a way to encapsulate this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've put the logic in a function of (value, format).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don’t see the change here. It looks like you did this for the Plot example but not the Google Analytics one. 😓
Also, I don’t think this really solves the problem I raised because someone still has to find the
trendfunction you wrote — we need to think about how to incorporate a practical solution “in the box” (in the standard library or default CSS).(And also I want inline expressions for attributes #32 or even better server-side rendering #234…)