-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse provided tag #203
Parse provided tag #203
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this approach. I think we should expose the parsed AST for the tag too.
thanks @mbostock!! 🙏 updated this so that one thing I wasn't totally sure about was whether |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last thing, let’s use CellTag as the name for these nodes instead of Tag?
I like the idea of keeping cell.async and cell.tag.async as independent because that doesn’t lose information and makes it easier for us to potentially do smarter things in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good though one more tiny thing!
When you land would you like me to do the major version bump and publish to npm, or would you like me to pair with you so I can show you how to do it?
@mbostock if you have a sec to pair on it this afternoon that'd be great! 🙏 |
An alternative to #202:
CellParser
relevant to determiningasync
and created a super basicTagParser
, but lmk if I'm misunderstanding the best way to do this 👍should only require a minor version bump?this will require a major version changeLike the original PR this also: