Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color legend. #23

Closed
mbostock opened this issue Nov 3, 2020 · 1 comment · Fixed by #583
Closed

Color legend. #23

mbostock opened this issue Nov 3, 2020 · 1 comment · Fixed by #583
Labels
enhancement New feature or request

Comments

@mbostock
Copy link
Member

mbostock commented Nov 3, 2020

When using a color legend (e.g., #2 #19), should we automatically include a nice legend (probably yes)?
@mbostock mbostock added the enhancement New feature or request label Nov 3, 2020
@mbostock mbostock mentioned this issue Dec 19, 2020
Closed
Fil added a commit that referenced this issue Jan 11, 2021
@Fil
first pass for legends
17e6126 
- implements color legend (#23)
@Fil Fil mentioned this issue Jan 11, 2021
Closed
8 tasks
@mbostock mbostock added this to the Friends Preview milestone Feb 24, 2021
@Fil Fil mentioned this issue Mar 4, 2021
Closed
@Fil
Copy link
Contributor

Fil commented Mar 11, 2021

Strategies to deal with long labels in swatches, if we don't use foreignObject/html:

  • measure text then cut/wrap (might not be possible without adding them to the DOM first?)
  • use a heuristic (as is D3 jetpack's wordwrap)
  • clip text to a rectangle

@Fil Fil mentioned this issue Mar 11, 2021
Open
Fil added a commit that referenced this issue Mar 12, 2021
@Fil
first pass for legends
14eef0a 
- implements color legend (#23)
@Fil Fil mentioned this issue Apr 5, 2021
Closed
@Fil Fil mentioned this issue Jun 13, 2021
Closed
6 tasks
This was referenced Aug 5, 2021
Closed
Merged
@mbostock mbostock mentioned this issue Nov 26, 2021
Merged
9 tasks
@Fil Fil closed this as completed in #583 Nov 29, 2021
@Fil Fil mentioned this issue Aug 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

legends - 2 observablehq/plot
legends and scales observablehq/plot
2 participants
@Fil @mbostock