Add support for margin to ordinal color legend. #1082
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fil
requested changes
Oct 11, 2022
src/legends/swatches.js
Outdated
Comment on lines
183
to
184
| ? `margin-bottom: 0.5em;` | ||
| : `margin-bottom: ${+marginBottom}px;` |
There was a problem hiding this comment.
this mix seems like a problem, not sure how to unify that properly. Should we default to the equivalent number of pixels, on line 93?
There was a problem hiding this comment.
I've updated it to default to 8px which should be the equivalent. What do you think?
|
Not sure what went on with the previous commit (32e26ed) but hopefully it's ok now. |
|
For me it seems like 5px instead of 8px would make it visually unchanged in the unit tests. |
|
I'm sorry I went back to the original idea, in order to minimize churn. Please add your review (or thumbs up or down) on #1090. Thank you for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1080 (reply in thread)