fix empty facet bug #1215
Closed
fix empty facet bug #1215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Superseded by #1216. |
mbostock
added a commit
that referenced
this pull request
Jan 17, 2023
* [] is an empty facet closes #1212 alternative to #1215 * consistent filtering Co-authored-by: Mike Bostock <[email protected]>
chaichontat
pushed a commit
to chaichontat/plot
that referenced
this pull request
Jan 14, 2024
* [] is an empty facet closes observablehq#1212 alternative to observablehq#1215 * consistent filtering Co-authored-by: Mike Bostock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the facet domain does not include any value from the actual contents, the facet index is undefined instead of [].
I'm not sure this is the correct fix, I have an alternative that moves a bit more things but seems better in #1216
closes #1212