-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
document stack #1352
document stack #1352
Conversation
Are you suggesting that we deprecate the x and y orders for the sake of parsimony, since they are equivalent to value? It’s implemented here: Lines 228 to 230 in 2ac08e2
Alternatively, are you suggesting that offer stricter validation, only letting you use the x order with stackX, and the y order with stackY? I think we could do that by having separate interfaces for StackXOptions and StackYOptions, but it’s so rare that I don’t think it’s worth doing. |
Thanks for the clarification. I was wanting to investigate what "x" or "y" did differently than "value", since I wasn't sure I remembered precisely. It's fine to keep them around as aliases, we just need to document them more clearly. |
Co-authored-by: Mike Bostock <[email protected]>
Co-authored-by: Mike Bostock <[email protected]>
* expand is deprecated; use normalize * normalize is the reference, expand the deprecated value * stackOptions * stack transforms * avoid duplications * mark *x* and *y* as being an alias of *value* * Update src/transforms/stack.d.ts Co-authored-by: Mike Bostock <[email protected]> * Update src/transforms/stack.d.ts Co-authored-by: Mike Bostock <[email protected]> * simpler * tweaks * Update README --------- Co-authored-by: Mike Bostock <[email protected]>
TODO/questions:
@deprecated
? Fixed in 2a71c9dremoveexplicit "x" | "y" in StackOrderName?for #1343