Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document box #1394

Merged
merged 4 commits into from
Mar 31, 2023
Merged

document box #1394

merged 4 commits into from
Mar 31, 2023

Conversation

Fil
Copy link
Contributor

@Fil Fil commented Mar 26, 2023

for #1343

Say what happens with stroke/z? In my view it's technically working but hard to see if you don't add fillOpacity, so maybe it needs a bit more work.

@Fil Fil requested a review from mbostock March 26, 2023 15:04
Copy link
Member

@mbostock mbostock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs a bit more explanation about the underlying group and map transforms.

@mbostock mbostock enabled auto-merge (squash) March 31, 2023 02:53
@mbostock mbostock merged commit 644d336 into main Mar 31, 2023
@mbostock mbostock deleted the fil/ts-box branch March 31, 2023 02:55
chaichontat pushed a commit to chaichontat/plot that referenced this pull request Jan 14, 2024
* document box

* remove unused accessor

* adopt identity transform

* edits

---------

Co-authored-by: Mike Bostock <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants