Fix CI and update go version and dependencies. #82
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a significantly bigger number of changes in here than I would have liked but I will try to explain the reasoning and what we are actually trying to fix.
Firstly, we have not had CI push a new image in over a year as can be seen by quay dashboard.
So it seems like CI has been broken for some time and lint also failed on the latest commit.
I was not able to run
make lint
locally (OS X) without panic so I updated the version which bubbled up a number of lint failures, the trivial ones I fixed. Also see #46The main reason for this change initially was to address some vulnerabilities which have now been rectified by the changes to
go.mod
. I also noticed #64 so updated those dependencies accordingly and will follow up with a fix for that.Pulling in the latest
k8s.io/*
intogo.mod
brought about the error seen in kubernetes-sigs/json#8 and noticing our intention to move some repos to go 1.1.17 (observatorium/api#262) I updated the Dockerfile and all relevant CI to take care of that here and allow us to proceed with fixing #64Finally, since we are using scratch in other components, I updated to scratch from distroless image (https://github.com/observatorium/token-refresher/blob/master/Dockerfile#L10) - This can be undone if we prefer.
End result is we are up-to-date and
docker scan
on the built images shows no vulnerabilities.Fixes #46
Precursor to closing #64