test: Fix assertions in Task tests & fix tests; thanks SonarLint #1724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SonarLint in WebStorm reports: Assertions should be complete. CodeSmell typescript: S2970 It is very easy to write incomplete assertions when using some test frameworks. It turns out that 4 of the tests were actually incorrect, but seemed to be passing because they were not asserting on the result.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Task.test.tsSonarLint in WebStorm reports:
It turns out that 4 of the tests were actually incorrect, but seemed to be passing because they were not asserting on the result.
Motivation and Context
See above.
How has this been tested?
Running the tests. They failed :-)
Screenshots (if appropriate)
Types of changes
Internal changes:
test- additions and improvements to unit tests and the smoke tests)Checklist
n/a
Terms