fix: render Tasks in canvas #1733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claremacrae
added
the
scope: rendering of tasks
|
Assigned to me for review. |
claremacrae
approved these changes
Mar 7, 2023
7 tasks
This was referenced Mar 22, 2023
claremacrae
added a commit
that referenced
this pull request
Mar 26, 2023
8 tasks
claremacrae
added a commit
that referenced
this pull request
Mar 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
If Tasks query is written in a card in Canvas it is not rendered.
Inspired by same PR in dataview plugin: blacksmithgu/obsidian-dataview#1661
Solves #1732
How has this been tested?
Tested on my live vault - created a card with
Tasks 1.25.0 is not rendering anything. With this fix - a list of tasks appears.
Unfortunately I can't imagine how to unit test this.
Screenshots (if appropriate)
Types of changes
Changes visible to users:
fix- non-breaking change which fixes an issue)feat- non-breaking change which adds functionality)feat!!orfix!!- fix or feature that would cause existing functionality to not work as expected)docs- improvements to any documentation content)vault- improvements to the Tasks-Demo sample vault)Internal changes:
refactor- non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)test- additions and improvements to unit tests and the smoke tests)chore- examples include GitHub Actions, issue templates)Checklist
yarn run lint.Terms