Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: query-related fields now have a "hidden" CSS class #1908

Merged
merged 2 commits into from
Apr 24, 2023

Conversation

esm7
Copy link
Contributor

@esm7 esm7 commented Apr 23, 2023

Description

Fixes the bug linked below, caused by the code that treats query fields (in contrast to task fields) not using the same flow.

Motivation and Context

Fixes #1866

How has this been tested?

  1. Checked using the Obsidian Developer Console.
  2. Added the relevant classes to the smoke tests in the test vault.

Screenshots (if appropriate)

Types of changes

Changes visible to users:

  • Bug fix (prefix: fix - non-breaking change which fixes an issue)
  • New feature (prefix: feat - non-breaking change which adds functionality)
  • Breaking change (prefix: feat!! or fix!! - fix or feature that would cause existing functionality to not work as expected)
  • Documentation (prefix: docs - improvements to any documentation content for users)
  • Sample vault (prefix: vault - improvements to the Tasks-Demo sample vault)
  • Contributing Guidelines (prefix: contrib - any improvements to documentation content for contributors - see Contributing to Tasks)

Internal changes:

  • Refactor (prefix: refactor - non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)
  • Tests (prefix: test - additions and improvements to unit tests and the smoke tests)
  • Infrastructure (prefix: chore - examples include GitHub Actions, issue templates)

Checklist

Terms

@esm7
Copy link
Contributor Author

esm7 commented Apr 23, 2023

Please note that with the default settings, this PR adds a tasks-layout-hide-urgency class to the query results HTML item that was not there before. This is because by default urgency is hidden, and I did not think that this fact justifies to make this setting inconsistent and work differently (e.g. have a tasks-layout-show-urgency class instead).

@claremacrae
Copy link
Collaborator

Trivia, for reference in future PRs...

@esm7 FYI I have edited the description so that it says:

Fixes https://github.com/obsidian-tasks-group/obsidian-tasks/issues/1866

This would also work and is displayed the same:

Fixes #1866

This way, GitHub detects the link between the PR and the issue, and will close the issue with appropriate link when the PR is merged..

@claremacrae claremacrae changed the title Fixes query-related fields not having a "hidden" class fix: query-related fields now have a "hidden" class Apr 24, 2023
@claremacrae claremacrae added the scope: css styling Changes to styling of elements displayed by Tasks, including search results and individual tasks label Apr 24, 2023
@claremacrae claremacrae changed the title fix: query-related fields now have a "hidden" class fix: query-related fields now have a "hidden" CSS class Apr 24, 2023
@claremacrae claremacrae merged commit 646268f into obsidian-tasks-group:main Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: css styling Changes to styling of elements displayed by Tasks, including search results and individual tasks
Projects
Status: 🎉 Released
Development

Successfully merging this pull request may close these issues.

Missing hidden components classes in HTML code
2 participants