-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump base and template-haskell bounds to enable GHC 9.10 #55
Conversation
Hello @ali-abrar (sorry for at-mentioning, but you seem to be the most active contributor), |
Thanks. We can drop support for the older GHCs as long as we note it in the changelog and update the tested-with field in the cabal file. I'd prefer to keep 8.6.5 if it isn't too much trouble (appears to be the last official release of ghcjs) and 8.10 (the most recent unofficial ghcjs release). |
The new GitHub action file looks fine to me. Thank you for the contribution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need to set the version (or decide this is a revision) so that these changes can be released. They can, however, be merged.
Once they pass CI, that is. |
Thank you ❤️ |
Hello,
this package is one of the transitive dependencies of haskell-language-server, which I'm trying to enable for GHC 9.10. Could you please release new 9.10-supporting version of this package to hackage?
Apart from bumping base and template-haskell upper bounds, I'm also I replacing defunct travis CI config with haskell-ci -generated github actions config.
You can see the new CI config in action in my fork: jhrcek#1
It seems that the build is failing with ghc 8.0.2 and 8.2.2. with error like this:
Would you prefer me trying to fix it, or would you be ok with dropping these 2 oldest GHC versions from tested-with / CI?
Also would you be ok with replacing the existing CI config with a one generated by haskell-ci?
Although the generated one is more verbose, I find it more comprehensive and easier to maintain (it bumps actions versions etc.)