Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ghc 9.6 in cabal build of skeleton and deps #1075

Merged
merged 5 commits into from
Nov 10, 2024

Conversation

alexfmpe
Copy link
Collaborator

@alexfmpe alexfmpe commented Apr 16, 2024

Just the usual backport of mtl un-re-exporting and shuffling around bindings to get around TH splices breaking visibility.

Pretty much everything is made to build up to 9.6 with backwards-compatible changes, except dependencies of ob, namely obelisk-selftest and obelisk-command, as the later's deps (e.g. git/hnix) won't build even with --allow-newer

Does not need reflex-frp/reflex-dom#469 to be merged, only to take advantage of the recent version

`nix-build release.nix -A build. worked for

  • x86_64-linux
  • aarch64-darwin
  • x86_64-darwin (rosetta)
  • Based work on latest develop branch
  • Followed the contribution guide
  • Looked for lint in my changes with hlint . (lint found code you did not write can be left alone)
  • Run the test suite: $(nix-build -A selftest --no-out-link)
  • Updated the changelog
  • (Optional) Run CI tests locally: nix-build release.nix -A build.x86_64-linux --no-out-link (or x86_64-darwin on macOS)

@alexfmpe
Copy link
Collaborator Author

alexfmpe commented Apr 26, 2024

Hadn't noticed I was relying on

package *
ghc-options: -Wwarn

until hitting build failures when building obelisk libs with nix.

Having -Werror on the packages but -Wwarn in cabal.project makes for downstream pain

@alexfmpe alexfmpe changed the title Support ghc 9.6 in build dependencies of obelisk apps Support ghc 9.6 in cabal build of obelisk skeleton and deps Apr 26, 2024
@alexfmpe alexfmpe changed the title Support ghc 9.6 in cabal build of obelisk skeleton and deps Support ghc 9.6 in cabal build of skeleton and deps Apr 26, 2024
@alexfmpe
Copy link
Collaborator Author

Ah hmm well, technically to build without nix I have to comment out the obelisk-generated-static bits since that's done by ob and obelisk-command depends on nix-thunk which cannot be built without nix. Since selftest also depends on obelisk-command this PR goes as far as cabal can go.

@ali-abrar ali-abrar merged commit 89d7378 into obsidiansystems:develop Nov 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants