Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make commit with thoughts from #120 description #121

Merged
merged 2 commits into from
Jan 2, 2020
Merged

Make commit with thoughts from #120 description #121

merged 2 commits into from
Jan 2, 2020

Conversation

Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented Dec 30, 2019 •
edited
Loading

@Ericson2314 Ericson2314 requested a review from 3noch December 30, 2019 17:02
@ali-abrar
Copy link
Member

This really ought to be an error

@3noch
Copy link
Collaborator

3noch commented Jan 2, 2020

@ali-abrar That's what I thought too however I think we may not be ready to break just about every app using this. I want to beef up MonoidMap so we can actually start using it and then pull the trigger there.

@3noch 3noch merged commit 25ca843 into develop Jan 2, 2020
@ali-abrar ali-abrar deleted the document-functorToWire-mapQuery branch November 20, 2021 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexfmpe alexfmpe alexfmpe left review comments

@3noch 3noch 3noch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ericson2314 @ali-abrar @3noch @alexfmpe