frontend-forms: Make the validation function Behavior -> BehaviorValidation --- blocked on #49 #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ericson2314
changed the base branch from
je-validation-error-param
to
develop
Ericson2314
changed the title
This is a hack to allow validation to take external state into account. We want that external state to only be something that can be pulled, never something that pushes validation. At least the DynValidation return type promotes merging with other `DynValidation`s.
Ericson2314
force-pushed
the
je-hack-in-external-validation
branch
from
e89876d to
2c123c9
Compare
Ericson2314
changed the title
This fixes an error where the user can cause validation errors to be displayed more often than they should. It also makes clear to the user though the type that they don't have that power (behaviors cannot push).
Ericson2314
changed the title
Useful for adding extra checks
User facing text should be provided by the caller
We need this to leak the original buttom click, so we can gate a new round of validation with it regardless of whether that will end up valid and trigger a response.
3noch
reviewed
Feb 28, 2019
3noch
reviewed
Feb 28, 2019
3noch
reviewed
Feb 28, 2019
A. One looses promptness on external changes, which is also valid, when
the whole point was promptness.
B. If one fires "revaluate" more often than the input changes, we do
want to resample the outside world. E.g. maybe an input becamse *more*
valid.
Plain behavior did B, What we have now does niether. But "full dynamic"
which is then gated does both.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows validation to take external state into account. Validation can pull external state, but never be pushed by it, as the validations make clear.