Add SQL QQ variants supporting anti-quotation of arbitrary Haskell expressions #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexfmpe
reviewed
Aug 19, 2019
| , quoteExp = \s -> appE [| uncurry traceExecute |] (sqlQExp s) | ||
| , quoteDec = error "traceQueryQ: quasiquoter used in declaration context" | ||
| } | ||
| traceExecuteQ = (defaultQQ "traceExecuteQ") { quoteExp = appE [| uncurry traceExecute |] . sqlQExp } | ||
|
|
||
| traceExecuteQ_ :: QuasiQuoter |
There was a problem hiding this comment.
Heh, traceExecuteQ and traceExecuteQ_ actually had wrong (referred to traceQueryQ) error messages
There was a problem hiding this comment.
So technically this is a semantic change. You know...for those people who are catching this and making choices based on the string of the message. 🤔 😉
3noch
force-pushed
the
eac@sql-qq-interpolate
branch
2 times, most recently
from
41ccd8d to
0e6e7e3
Compare
… arbitrary Haskell expression
3noch
force-pushed
the
eac@sql-qq-interpolate
branch
from
0e6e7e3 to
79f07eb
Compare
|
I pulled all the clean up into #93. Thus this MR only deals with the new QQs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.