-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HTTP/2 and Brotli support #184
base: master
Are you sure you want to change the base?
Conversation
Unfortunately, OBS Studio is not the only binary relying on curl, some plugins do. So building statically is not a good thing, it will introduce duplication of the curl lib in various binaries. |
Please be specific. What plugins rely on curl? |
|
Honestly, not worth caring about. It's a few kilobytes or maybe a megabyte. But it's either that or compiling Curl and it's dependencies twice. |
2a75c82
to
fb6f717
Compare
Just to leave some notes on where this PR is at:
|
On libcurl, I would prefer that if it needs changes, that those changes are done on the curl repo. They release pretty frequently these days. |
Based on some discussions off-thread we can probably use the dynamic CRT instead of static even for the updater, which makes things a little easier (see my standalone updater repo). I don't even know where to start with the cmake changes or if upstream would even care about them. |
Description
Adds brotli and nghttp2 libraries to curl for HTTP/2 and brotli compression support. Also switches curl to being a static library.
Motivation and Context
Currently all HTTP traffic OBS receives is uncompressed, which is wasting bandwidth. Additionally, we want to use HTTP/2 for multiplexing and asnychronous requests in the updater and possibly other parts of OBS.
How Has This Been Tested?
Built locally, but needs to be checked more thouroughly as updater changes are still in progress and we might need to build curl with a static VCRT for it (and thus probably twice in total), so the PR is a draft.
Types of changes
Checklist: