Skip to content

Commit

Permalink
obs-outputs: Switch RTMP color metadata order
Browse files Browse the repository at this point in the history
Sends color metadata before the video header for RTMP streams. Only
applicable to HDR RTMP streams. Ensures the server sees the correctly
configured color metadata first, in cases where the decoder config in
the video header has incorrect or missing color information. Mitigates a
bug that users with outdated AMD drivers may encounter.
  • Loading branch information
nquah authored and RytoEX committed Jan 3, 2024
1 parent f6c8fe7 commit f1f5b34
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions plugins/obs-outputs/rtmp-stream.c
Original file line number Diff line number Diff line change
Expand Up @@ -923,8 +923,6 @@ static inline bool send_headers(struct rtmp_stream *stream)

if (!send_audio_header(stream, i++, &next))
return false;
if (!send_video_header(stream))
return false;

// send metadata only if HDR
video_t *video = obs_get_video();
Expand All @@ -934,6 +932,9 @@ static inline bool send_headers(struct rtmp_stream *stream)
if (!send_video_metadata(stream)) // Y2023 spec
return false;

if (!send_video_header(stream))
return false;

while (next) {
if (!send_audio_header(stream, i++, &next))
return false;
Expand Down

0 comments on commit f1f5b34

Please sign in to comment.