-
-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clear text password and username #8966
Comments
How this closed as completed , ?? |
@fu2x2000 Because the |
thanks for the clarification |
Just so you know, a CVE was assigned even though it probably should be disputed in this particular case. https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2023-34585 A project maintainer may dispute a CVE through this process: https://www.cve.org/Resources/General/Policies/CVE-Record-Dispute-Policy.pdf |
sure no worries , thanks for the heads up , though i would like few point of improvements in future.
many thanks fu2x2000 |
I originally ignored this issue because of how ridiculous it was, but to explain with further clarity: This is reporting the translation string of the word "Password". This is immediately obvious to anyone who spent more than half a second looking at the search results in the repository for the word "Password", which appears to be what was done here, without any actual validation of a problem or issue. I will respond to your direct comments here since you are the reporter @fu2x2000
You have failed the most basic validation of this report while submitting, and have now wasted both your time, and the time of several project members as we now have to dispute this to get a false security risk removed. At best, this was a grossly negligent report, and at worst, intentionally false to try and boost reputation by making CVE reports. Please do better in the future. |
Hi to you to explain i have made this finding through ascript i created , where to identify sensitive key pairs. i have not necessary done projects with OBS nether did the research with the product , hence the reason creating a issue than in to bug bounty program. Now to reason explain my previous comment ini file can have various configuration values that could be possibly a password. from my prospective i report what have seen as a threat .i report a issue first not a cve if any one close the ticket with proper explanation i would not apply for a cve after 3 weeks after creating the issue. see whose fault is that now . i guess all should do better in future. |
An ini file can contain any sort of key-value pairs, if in this particular case you used locale ES and changed the string, the text in OBS would change as well, the password that a user actually entered would not be there. You may want to rework your script because its pulling in a lot of false positives very likely. |
thanks for the advice , its not specifically made for OBS software, then again you are correct there is a room for improvement. i will request cve to be update as withdraw . |
Just for the record, we explained that this was a translation string, in the comment here: #8966 (comment) You failed to read that comment, on your own report. That is not our failure, that is yours. Any security researcher who submits reports without validating them should probably consider a new career path, as that kind of gross negligence isn't acceptable anywhere in the field. |
Also in the future, you should probably not just rely on a script, but rather invest a few minutes to read and check the supposed issue... even taking a proper look at the file you reported, would have made it obvious that this is a simple translation file and does not leak default passwords or anything |
You shouldn't even be making CVEs without even verifying that it's an actual vulnerability. This is so grossly negligent of pen-testing duties. It wastes time for people who could be improving their product instead of disputing false claims like this one. |
Operating System Info
Other
Other OS
No response
OBS Studio Version
29.1.1
OBS Studio Version (Other)
No response
OBS Studio Log URL
obs-studio/UI/data/locale/ca-ES.ini
Line 323 in adb7029
OBS Studio Crash Log URL
No response
Expected Behavior
in the directory OBS-studio/Ui/data/locale/ca-ini
ini file save's password in clear text which could lead to compromise. santizing password and username using via keystore would applicable
ex:
obs-studio/UI/data/locale/ca-ES.ini
Line 323 in adb7029
check above mention example line 726 and 727
Current Behavior
research based manage to discover the issue
Steps to Reproduce
1.Go to directory file OBS-studio/Ui/data/locale/ca-ini
2.open ini file in notepad
3.Search for password.
...
Anything else we should know?
N/A
The text was updated successfully, but these errors were encountered: