Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obs-outputs: Enable HDR for HEVC over RTMP #10029

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

nquah
Copy link
Contributor

@nquah nquah commented Dec 21, 2023

Removes flag guard to enable HDR streaming for HEVC over enhanced-RTMP. This functionality is currently only supported by YouTube. See github.com/veovera/enhanced-rtmp for the enhanced-RTMP spec.

Description

HDR support for RTMP was previously added in #8522, according to the enhanced-RTMP spec at github.com/veovera/enhanced-rtmp. This change partially removes the flag guard, to enable streaming HDR with HEVC over RTMP.

Motivation and Context

Enables streaming HDR with HEVC over RTMP to YouTube.

Notes:

  • Streaming HDR with HEVC to YouTube is already supported via HLS in OBS. This enables the capability via RTMP.
  • Streaming HDR with AV1 over RTMP to YouTube is not officially supported at this time.

How Has This Been Tested?

Tested against YouTube with Nvidia RTX 4090, Intel Arc A750, AMD RX 7900 XTX.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

Removes flag guard to enable HDR streaming for HEVC over enhanced-RTMP.
This functionality is currently only supported by YouTube. See
github.com/veovera/enhanced-rtmp for the enhanced-RTMP spec.
@RytoEX RytoEX self-assigned this Dec 21, 2023
@RytoEX RytoEX added Enhancement Improvement to existing functionality New Feature New feature or plugin labels Dec 21, 2023
@RytoEX RytoEX added this to the OBS Studio (Next Version) milestone Dec 21, 2023
@Fenrirthviti
Copy link
Member

As a note, this requires #10028 to be resolved first.

Copy link
Member

@RytoEX RytoEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. I don't think we need to block on #10028. The main known benefit of #10028 is to mitigate a bug with AMD users on outdated drivers. AMD users on current drivers should have no issues.

@RytoEX RytoEX merged commit 14db148 into obsproject:master Jan 3, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improvement to existing functionality New Feature New feature or plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants