cmake: Update MbedTLS finder to support MSVC Debug configuration #10081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Natively compiled MbedTLS for Windows will use the non-debug platform library, which will lead to a linker error when building OBS in debug configuration with MSVC. Neutralizing the linker directive for Debug builds on Windows unbreaks the build configuration without the need to ship separate debug variants of MbedTLS.
PatTheMav
added
Bug Fix
RytoEX
approved these changes
Jan 8, 2024
There was a problem hiding this comment.
Can confirm that this fixes building in Debug against obsproject/obs-deps#186. RelWithDebInfo also works.
Can still build in Debug and RelWithDebInfo with current deps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove
DEFAULTLIBdirective of MbedTLS for Debug builds on Windows.Motivation and Context
Natively compiled MbedTLS for Windows will use the non-debug platform library, which will lead to a linker error when building OBS in debug configuration with MSVC.
Neutralizing the linker directive for Debug builds on Windows unbreaks the build configuration without the need to ship separate debug variants of MbedTLS.
How Has This Been Tested?
Tested on Windows 11 with natively compiled MbedTLS static libraries.
Types of changes
Checklist: