-
-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
frontend: Add support for TEB/Multitrack Video to macOS (arm64 only) #11440
base: master
Are you sure you want to change the base?
frontend: Add support for TEB/Multitrack Video to macOS (arm64 only) #11440
Conversation
36502f5
to
467ade6
Compare
Configuration API support for macOS is now rolling out into production, within the next few days this PR should be testable by anyone. |
The server-side changes have now rolled out, so this PR can be tested by anybody who wishes to do so! |
467ade6
to
037e056
Compare
037e056
to
0ee9591
Compare
0ee9591
to
fa66f51
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably add a license header to frontend/utility/system-info-macos.mm
. That need not be done here, but it would be fine to include here.
Prefix should be frontend:
.
@PatTheMav I'd appreciate a quick glance to make sure the includes/imports are as preferred.
fa66f51
to
aed7abe
Compare
@@ -1,6 +1,96 @@ | |||
#include "system-info.hpp" | |||
|
|||
#ifdef __aarch64__ | |||
#include <util/platform.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can just use #import
everywhere, there is no technical reason not to for ObjC except for possible cosmetic reasons.
Also correct order per the new rules (case-sensitive sort if there is no technical reason for a different order) should be:
#import <Foundation/Foundation.h>
#import <Foundation/NSProcessInfo.h>
#import <sys/sysctl.h>
#import <sys/types.h>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can just use #import everywhere, there is no technical reason not to for ObjC except for possible cosmetic reasons.
Yeah I just kept using include for C and import for ObjC, but I can change it for both.
Also correct order per the new rules (case-sensitive sort if there is no technical reason for a different order) should be:
Are these "new rules" documented anywhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only by example, all new frontend files' includes have been arranged that way (and if they aren't it'd be an error).
The general order:
- Header associated with source file
- Other header files from the same project
- Header files from non-standard library
- Header files from standard library
Is more or less an established good-practice anyway. Sorting case-sensitive has the additional benefit of putting C++ classes (or in this case ObjC frameworks) as high-level language objects before low-level language objects almost automatically.
Thus the order of includes on a micro-level align neatly with the order of includes on a macro-level:
- Headers associated with larger frameworks or classes, mostly OO
- Headers associated with bare code and type definitions, mostly non-OO
So the further down in the includes, the more "low-level" the include is.
aed7abe
to
6395e7a
Compare
Description
Adds TEB support for macOS on Apple Silicon.
Motivation and Context
Want to support all users, including macOS/Linux (Linux tbd).
The small number of SKUs makes Apple Silicon easy, and since Intel Macs are losing support it seems fine to only support ARM.
Note: GetClientConfiguration API changes have not yet rolled out into production.
How Has This Been Tested?
Locally with Twitch staging environment.
Types of changes
Checklist: