obs-outputs: Fix HEVC/RTMP composition time #8650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there! Just as a minor nitpick, please make sure to use present tense rather than past tense in PRs and commits. |
derrod
approved these changes
Apr 4, 2023
jp9000
changed the title
nquah
force-pushed
the
enhanced-rtmp-hevc-fix
branch
from
5db749a to
34e98b4
Compare
Fixes bug in Enhanced RTMP implementation. Populates non-zero HEVC composition times in the FLV extended video tag header.
derrod
force-pushed
the
enhanced-rtmp-hevc-fix
branch
from
34e98b4 to
597d74c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug in Enhanced RTMP implementation, where HEVC streams with B-frames enabled are not adhering to the spec.
Credit to derrod
Description
Populates non-zero composition times in the FLV extended video tag header for HEVC streams.
Motivation and Context
See #8522 for context.
The Enhanced RTMP spec provides an optimization where HEVC streams without B-frames do not need to send a composition time of 3 bytes (with value 0) for every frame.
This patch fixes a bug: Composition times are just not getting set at all, instead of only when the value of the composition time is 0.
How Has This Been Tested?
We ran streams against YouTube, inspected the bitstream and confirmed that composition times are correctly set.
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: