obs-outputs: Enable HDR for HEVC over RTMP #9264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes flag guard to enable HDR streaming for HEVC over Enhanced RTMP. This functionality is currently only supported by YouTube. See github.com/veovera/enhanced-rtmp for the Enhanced RTMP spec.
|
FWIW the AMD encoder issue is something that also affects recorded videos, see #9195. The AMD encoder wasn't meaningfully changed between those versions but ffmpeg itself also no longer detects it as HDR. A bitstream analyser still shows the correct data being set however. |
derrod
approved these changes
Jul 18, 2023
|
I can confirm that despite #9195, it seems to me to work fine streaming to YT via RTMPS with HDR. I believe that issue only affects the ffmpeg mux process. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes flag guard to enable HDR streaming for HEVC over Enhanced RTMP. This functionality is currently only supported by YouTube. See github.com/veovera/enhanced-rtmp for the Enhanced RTMP spec.
Description
HDR support for RTMP was previously added in #8522, according to the Enhanced RTMP spec at github.com/veovera/enhanced-rtmp. This change partially removes the flag guard, to enable streaming HDR with HEVC over RTMP.
Motivation and Context
Enables streaming HDR with HEVC over RTMP to YouTube, which now supports this functionality.
How Has This Been Tested?
Tested against YouTube with Nvidia RTX 4090, Intel Arc A750, AMD RX 7900 XTX.
Known issues: HDR not correctly detected by YouTube on AMD encoder. Debugging in progress.
Types of changes
Checklist: