-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
obs-webrtc: Add AV1 Support #9331
Conversation
bd122c2
to
74973a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those changes must be guarded behind #if version (e.g. 1.19.0 since it is not released), some distro will not use an alpha version to build OBS Studio.
@tytan652 We use an alpha version of libdatachannel today. No stable release of libdatachannel exists that can be used with OBS. I can ask for a stable release if packagers/distros want. Since libdatachannel isn't packaged anywhere I anticipate WebRTC will be disabled in most places :( |
So I am off-topic: It was already available on the AUR (ArchLinux User Repo) with author of libdatachannel help since a while. So people that build obs-studio-git have bad build of the webrtc plugin and my dev machine too. Edit: I repeat this is off-topic. |
e34c3d9
to
2517083
Compare
Please get a released version in place for OBS (and packagers) to depend on. |
@Conan-Kudo, this is off-topic of the PR. |
I'll just throw in one very final thing on that off-topic discussion here: there's no need to rush things. I'd agree with @Conan-Kudo and @tytan652. But don't push public packages to release alpha as stable, make sure it's fully stabilized. Let's just all have patience. 🙂 (Also it would be nice if there were version macros) Glad to see more AV1 PRs. |
@Lain-B Good news! AV1 is now available in stable Post v30.0 would it be ok to update the deps and enable AV1 for OBS? |
9e9c470
to
6f0b986
Compare
AV1 is now available in the libdatachannel that OBS uses. This PR is ready for review/merge. |
Hi guys When setting the keyframe interval to 1 second, the video experiences frequent interruptions. The testing environment is 1920x1080 at 60fps with a bitrate of 6000 Kbps. This happening on Windows, using an Intel 12900k, Geforce 4090. |
Description
This adds AV1 support to obs-webrtc
Motivation and Context
Users wish to use AV1
How Has This Been Tested?
Tested against Broadcast Box
Types of changes
Checklist: