Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils: Use u8path to fix possible string conversion crashes on Windows #1282

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PatTheMav
Copy link
Member

Description

Use u8path when creating a file system path via a provided std::string.

Motivation and Context

All other path operations in the code base already use u8path to ensure that the strings provided by libobs (which will either be ASCII or UTF-8 byte sequences) are correctly converted into UTF-16 strings.

Fixes #1244.

How Has This Been Tested?

Has not been tested locally, will need simple reproducer first.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have read the Contributing Guidelines.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • My code is not on master or a release/* branch.
  • The code has been tested.
  • I have included updates to all appropriate documentation.

@RytoEX RytoEX self-assigned this Feb 12, 2025
All other path operations in the code base already use u8path to ensure
that the strings provided by libobs (which will either be ASCII or
UTF-8 byte sequences) are correctly converted into UTF-16 strings.
@PatTheMav PatTheMav force-pushed the windows-filename-fix branch from 9e7b20d to 8cc8b72 Compare February 12, 2025 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unicode username causing OBS won't launch in normal mode
2 participants