Add mute source commands #37
Conversation
|
|
||
| obs_source_t* item = obs_get_source_by_name(item_name); | ||
| if (!item) { | ||
| owner->SendErrorResponse("invalid request parameters"); |
There was a problem hiding this comment.
Please add a return instruction after calling SendErrorResponse.
|
|
||
| obs_source_t* item = obs_get_source_by_name(item_name); | ||
| if (!item) { | ||
| owner->SendErrorResponse("specified source doesn't exist"); |
There was a problem hiding this comment.
Same remark here as line 403.
PROTOCOL.md
Outdated
| @@ -236,6 +236,20 @@ __Request fields__ : | |||
| __Response__ : OK if source exists, with these additional fields : | |||
| - **"name"** (string) : name of the requested source | |||
| - **"volume"** (double) : volume of the requested source, on a linear scale (0.0 to 1.0) | |||
| - **"muted"** (bool) : mute status of the requested source | |||
|
|
|||
| ### "SetMute" | |||
There was a problem hiding this comment.
The title is one level too high. Should be #### "SetMute" instead of ### "SetMute"
PROTOCOL.md
Outdated
| - **"source"** (string) : the name of the source | ||
| - **"mute"** (bool) : the desired mute status | ||
|
|
||
| ### "ToggleMute" |
There was a problem hiding this comment.
Same as line 241 : should be #### "ToggleMute instead.
|
@Palakis Thanks for the review, and thanks for this great project! This project has helped the stream group I'm involved with immensely. I've addressed the items in your review. |
|
Looking forward to this being packaged and released. I'm having to do mouseclicks to mute right now and it is painful. Thanks guys. |
|
Once this nasty and tricky bug is fixed, I'll be able to package a new binary release. |
Implements ToggleMute (inverts source's mute) and SetMute (sets mute to true or false).