Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for sparse YOLOv5 models from SparseZoo #847

Closed
wants to merge 39 commits into from

Conversation

mwitiderrick
Copy link
Contributor

@fcakyon
Copy link
Collaborator

fcakyon commented Mar 13, 2023

@mwitiderrick, thanks a lot!

Firstly can you please reformat your code as given here: https://github.com/obss/sahi#contributing

And could you include some tests and a demo inference notebook in this PR?

For the notebook, you can take this as a reference: https://github.com/obss/sahi/blob/main/demo/inference_for_yolov5.ipynb

Reference for the tests: https://github.com/obss/sahi/blob/main/tests/test_yolov5model.py

@fcakyon
Copy link
Collaborator

fcakyon commented Mar 14, 2023

@mwitiderrick can you please reformat your code as given here: https://github.com/obss/sahi#contributing ? And commit/push again?

@mwitiderrick
Copy link
Contributor Author

Hello @fcakyon added the tests, demo notebook and formatted the code

@fcakyon
Copy link
Collaborator

fcakyon commented Mar 14, 2023

@mwitiderrick thanks a lot!

Can you please add deepsparse installation into ci configs?

- name: Install ultralytics

- name: Install ultralytics

@mwitiderrick
Copy link
Contributor Author

add deepsparse installation into ci configs

@fcakyon done please check and let me know if it's as expected

@fcakyon
Copy link
Collaborator

fcakyon commented Mar 14, 2023

@mwitiderrick your tests are failing 🤔

@mwitiderrick
Copy link
Contributor Author

@mwitiderrick your tests are failing 🤔
@fcakyon tested and they worked.

DeepSparse doesn't support macos for now. Could it be the problem?
image

@fcakyon
Copy link
Collaborator

fcakyon commented Mar 14, 2023

Can you update the sparse yolov5 test file, so it doesn't run in macos? As in https://github.com/obss/sahi/blob/main/tests/test_detectron2.py#L18

@mwitiderrick
Copy link
Contributor Author

mwitiderrick commented Mar 14, 2023

Can you update the sparse yolov5 test file, so it doesn't run in macos? As in https://github.com/obss/sahi/blob/main/tests/test_detectron2.py#L18

@fcakyon looks good now?

@fcakyon
Copy link
Collaborator

fcakyon commented Mar 14, 2023

It also fails in windows and linux

@mwitiderrick
Copy link
Contributor Author

It also fails in windows and linux

Hello @fcakyon we did some fixes on DeepSparse to make it work with SAHI

These changes have not yet been released to pypi so I am installing from source.

DeepSparse only works on Linux.

Why are the tests also running on Windows and macos even after instructing that they only run for Linux?

@mwitiderrick
Copy link
Contributor Author

I'll close this one because of the many formatting issues new PR #848

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants