-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for sparse YOLOv5 models from SparseZoo #847
Conversation
@mwitiderrick, thanks a lot! Firstly can you please reformat your code as given here: https://github.com/obss/sahi#contributing And could you include some tests and a demo inference notebook in this PR? For the notebook, you can take this as a reference: https://github.com/obss/sahi/blob/main/demo/inference_for_yolov5.ipynb Reference for the tests: https://github.com/obss/sahi/blob/main/tests/test_yolov5model.py |
@mwitiderrick can you please reformat your code as given here: https://github.com/obss/sahi#contributing ? And commit/push again? |
Hello @fcakyon added the tests, demo notebook and formatted the code |
@mwitiderrick thanks a lot! Can you please add deepsparse installation into ci configs? Line 104 in 7d63528
sahi/.github/workflows/ci_torch1.10.yml Line 111 in 7d63528
|
@fcakyon done please check and let me know if it's as expected |
@mwitiderrick your tests are failing 🤔 |
DeepSparse doesn't support macos for now. Could it be the problem? |
Can you update the sparse yolov5 test file, so it doesn't run in macos? As in https://github.com/obss/sahi/blob/main/tests/test_detectron2.py#L18 |
@fcakyon looks good now? |
It also fails in windows and linux |
Hello @fcakyon we did some fixes on DeepSparse to make it work with SAHI These changes have not yet been released to pypi so I am installing from source. DeepSparse only works on Linux. Why are the tests also running on Windows and macos even after instructing that they only run for Linux? |
I'll close this one because of the many formatting issues new PR #848 |
Link to notebook
https://colab.research.google.com/drive/13t7KgZFQPZNx4JnqxoWKyTlIho7PKz9x?usp=sharing