Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace callable with Closure as return type declaration #114

Open
wants to merge 1 commit into
base: feature/graphql
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions classes/api/collection/AbstractCollectionType.php
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
<?php namespace Lovata\Toolbox\Classes\Api\Collection;

use Lovata\Toolbox\Classes\Api\Type\AbstractApiType;

use GraphQL\Type\Definition\ResolveInfo;
use GraphQL\Type\Definition\Type;

use Lovata\Toolbox\Classes\Api\Type\AbstractApiType;
use Lovata\Toolbox\Classes\Collection\ElementCollection;
use Lovata\Toolbox\Classes\Item\ElementItem;

use Closure;
use Illuminate\Support\Arr;
use Str;

Expand Down Expand Up @@ -41,9 +42,9 @@ public function addArguments(array $arArgumentList)

/**
* Get resolve method for type
* @return callable|null
* @return Closure|null
*/
protected function getResolveMethod(): ?callable
protected function getResolveMethod(): ?Closure
{
return function ($obValue, $arArgumentList, $sContext, ResolveInfo $obResolveInfo) {
//Check client authorization
Expand Down
5 changes: 3 additions & 2 deletions classes/api/item/AbstractItemType.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
use Lovata\Toolbox\Classes\Api\Type\AbstractApiType;
use Lovata\Toolbox\Classes\Api\Type\Custom\Type as CustomType;

use Closure;
use Illuminate\Support\Arr;
use Lang;
use Str;
Expand All @@ -27,9 +28,9 @@ abstract class AbstractItemType extends AbstractApiType

/**
* Get resolve method for type
* @return callable|null
* @return Closure|null
*/
protected function getResolveMethod(): ?callable
protected function getResolveMethod(): ?Closure
{
return function ($obValue, $arArgumentList, $sContext, ResolveInfo $obResolveInfo) {
//Check client authorization
Expand Down
12 changes: 7 additions & 5 deletions classes/api/mutation/AbstractMutationType.php
Original file line number Diff line number Diff line change
@@ -1,14 +1,16 @@
<?php namespace Lovata\Toolbox\Classes\Api\Mutation;

use GraphQL\Type\Definition\ResolveInfo;
use Lovata\Toolbox\Classes\Api\Type\Custom\Type as CustomType;
use GraphQL\Type\Definition\Type;

use Lovata\Toolbox\Classes\Api\Response\ApiDataResponse;
use Lovata\Toolbox\Classes\Api\Type\Custom\Type as CustomType;
use Lovata\Toolbox\Classes\Api\Type\AbstractApiType;

use DB;
use Closure;
use Illuminate\Validation\ValidationException;
use GraphQL\Type\Definition\Type;
use Lang;
use DB;

/**
* Class AbstractMutationType
Expand Down Expand Up @@ -62,9 +64,9 @@ protected function getFieldList(): array

/**
* Get resolve method for type
* @return callable|null
* @return Closure|null
*/
protected function getResolveMethod(): ?callable
protected function getResolveMethod(): ?Closure
{
return function ($obValue, $arArgumentList, $sContext, $obResolveInfo) {
$this->arArgumentList = $arArgumentList;
Expand Down
14 changes: 7 additions & 7 deletions classes/api/type/AbstractApiType.php
Original file line number Diff line number Diff line change
@@ -1,20 +1,20 @@
<?php namespace Lovata\Toolbox\Classes\Api\Type;

use Event;
use Closure;
use Illuminate\Support\Arr;

use GraphQL\Type\Definition\InputObjectType;
use GraphQL\Type\Definition\ObjectType;

use Lang;
use Lovata\Toolbox\Classes\Api\PermissionContainer;
use Lovata\Toolbox\Classes\Api\Response\ApiDataResponse;
use Lovata\Toolbox\Classes\Helper\UserHelper;

use October\Rain\Extension\ExtendableTrait;
use October\Rain\Support\Traits\Singleton;

use Event;
use Closure;
use Lang;
use Illuminate\Support\Arr;

/**
* Class AbstractApiType
* @package Lovata\Toolbox\Classes\Api\Type
Expand Down Expand Up @@ -211,9 +211,9 @@ protected function getTypeConfig(): array

/**
* Get resolve method for type
* @return callable|null
* @return Closure|null
*/
protected function getResolveMethod(): ?callable
protected function getResolveMethod(): ?Closure
{
return null;
}
Expand Down