-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve conflicts in runtime/ #2794
Conversation
@stedolan I think this is ready for you to look at. There are some Changes for |
Runtime changes that are specific to flambda‐backend should be useful when reviewing too. |
How much testing has this had? |
This compiles |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a first round of review, generally looking good so far.
I made a bunch of notes of areas I need to look at in more detail, so there'll be another round of comments later.
* Initial state where runtime builds * Review (cherry picked from commit e41be34) * Review of conflicts * Remove XXX in memprof files (cherry picked from commit 58e7b16) * ptrdiff_t (cherry picked from commit e4b4388) * domain.c:778 to stay deleted (cherry picked from commit f05df07) * Fix memprof bit in domain.c:domain_create (cherry picked from commit 34925f4) * Revert to upstream compaction behaviour in gc_ctrl.c (cherry picked from commit 7740dc4) * Fix for gettimeofday (cherry picked from commit d2f2330) * Typo fix (cherry picked from commit 2db34fd) * Remove XXX in caml_enter_blocking_section * Remove message in caml_enter_blocking_section for async exn raise * Remove XXX in caml_ba_alloc * adopt_orphaned_work * caml_alloc_custom_mem * Try to fix DEBUG code in platform.c * Resurrect CHECK_STACK_ALIGNMENT macro * Dune build fixes for the runtime - may need a bit more tidying * git rm s390x.S win32.c power.S riscv.S
This is not yet ready for review.
List of upstream changes involved:
https://github.com/ocaml-flambda/flambda-backend/wiki/List-of-upstream-changes-from-5.1.1-to-5.2.0-split-by-area#runtime