Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve conflicts in runtime/ #2794

Merged
merged 19 commits into from
Aug 13, 2024
Merged

Conversation

mshinwell
Copy link
Collaborator

@mshinwell mshinwell commented Jul 16, 2024

@mshinwell mshinwell marked this pull request as draft July 16, 2024 15:56
(cherry picked from commit e41be34)
@mshinwell
Copy link
Collaborator Author

@stedolan I think this is ready for you to look at. There are some XXX comments for you pointing out a few specific places that need extra checking. In addition to the diff here, another useful diff to look at for some files (e.g. major_gc.c is the diff against 1b2c8e5e55, which corresponds to the flambda-backend revision at the point of merging in the upstream 5.2.0 tag.

Changes for systhreads will be in a separate PR.

@mshinwell
Copy link
Collaborator Author

mshinwell commented Aug 9, 2024

Runtime changes that are specific to flambda‐backend should be useful when reviewing too.

@stedolan
Copy link
Contributor

How much testing has this had?

@mshinwell
Copy link
Collaborator Author

This compiles libcamlrun.a and libasmrun.a but hasn't been tested beyond that yet.

Copy link
Contributor

@stedolan stedolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a first round of review, generally looking good so far.

I made a bunch of notes of areas I need to look at in more detail, so there'll be another round of comments later.

ocaml/runtime/caml/backtrace.h Outdated Show resolved Hide resolved
ocaml/runtime/caml/memprof.h Outdated Show resolved Hide resolved
ocaml/runtime/memprof.c Outdated Show resolved Hide resolved
ocaml/runtime/platform.c Show resolved Hide resolved
ocaml/runtime/unix.c Outdated Show resolved Hide resolved
ocaml/runtime/domain.c Outdated Show resolved Hide resolved
ocaml/runtime/domain.c Outdated Show resolved Hide resolved
ocaml/runtime/gc_ctrl.c Outdated Show resolved Hide resolved
(cherry picked from commit 58e7b16)
(cherry picked from commit e4b4388)
(cherry picked from commit f05df07)
(cherry picked from commit d2f2330)
(cherry picked from commit 2db34fd)
ocaml/runtime/signals.c Outdated Show resolved Hide resolved
ocaml/runtime/signals.c Outdated Show resolved Hide resolved
ocaml/runtime/bigarray.c Outdated Show resolved Hide resolved
ocaml/runtime/major_gc.c Outdated Show resolved Hide resolved
ocaml/runtime/custom.c Outdated Show resolved Hide resolved
@mshinwell mshinwell marked this pull request as ready for review August 13, 2024 11:10
@mshinwell mshinwell merged commit 30489cb into ocaml-flambda:merge-5.2 Aug 13, 2024
1 of 18 checks passed
lukemaurer pushed a commit to lukemaurer/flambda-backend that referenced this pull request Oct 23, 2024
* Initial state where runtime builds

* Review

(cherry picked from commit e41be34)

* Review of conflicts

* Remove XXX in memprof files

(cherry picked from commit 58e7b16)

* ptrdiff_t

(cherry picked from commit e4b4388)

* domain.c:778 to stay deleted

(cherry picked from commit f05df07)

* Fix memprof bit in domain.c:domain_create

(cherry picked from commit 34925f4)

* Revert to upstream compaction behaviour in gc_ctrl.c

(cherry picked from commit 7740dc4)

* Fix for gettimeofday

(cherry picked from commit d2f2330)

* Typo fix

(cherry picked from commit 2db34fd)

* Remove XXX in caml_enter_blocking_section

* Remove message in caml_enter_blocking_section for async exn raise

* Remove XXX in caml_ba_alloc

* adopt_orphaned_work

* caml_alloc_custom_mem

* Try to fix DEBUG code in platform.c

* Resurrect CHECK_STACK_ALIGNMENT macro

* Dune build fixes for the runtime - may need a bit more tidying

* git rm s390x.S win32.c power.S riscv.S
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants