Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move float32 back to beta #2843

Merged
merged 3 commits into from
Jul 24, 2024
Merged

Move float32 back to beta #2843

merged 3 commits into from
Jul 24, 2024

Conversation

ncik-roberts
Copy link
Contributor

Move float32 back to stdlib_beta. That's both Float32 and Float32_u. That involves:

  • copying architecture-specific rules from stdlib_stable to stdlib_beta.
  • sedding Stdlib_stable.Float32 back to Stdlib_beta.Float32
  • reworking the library dependencies of some tests.

We can revert this when float32 is ready to be moved back to stable.

@ncik-roberts ncik-roberts merged commit 4846e6c into main Jul 24, 2024
18 checks passed
@ncik-roberts ncik-roberts deleted the move-float32-back-to-beta branch July 24, 2024 17:38
ncik-roberts added a commit that referenced this pull request Jul 24, 2024
@ncik-roberts
Move float32 back to beta (#2843)
67af442 
* Move float32 back to beta

* Fix `make runtest`

* Fix runtime5 tests

(cherry picked from commit 4846e6c)
TheNumbat added a commit that referenced this pull request Aug 9, 2024
@TheNumbat
Revert "Move float32 back to beta (#2843)"
11e906d 
This reverts commit 4846e6c.
TheNumbat added a commit that referenced this pull request Aug 14, 2024
@TheNumbat
Move float32 back to stable (#2915)
b793204 
* Revert "Move float32 back to beta (#2843)"

This reverts commit 4846e6c.

* fix test

* upstream_compatible test

* upstream_compatible simd test
lukemaurer pushed a commit to lukemaurer/flambda-backend that referenced this pull request Oct 23, 2024
@ncik-roberts
flambda-backend: Move float32 back to beta (ocaml-flambda#2843)
0889608 
* Move float32 back to beta

* Fix `make runtest`

* Fix runtime5 tests
lukemaurer pushed a commit that referenced this pull request Oct 23, 2024
@TheNumbat
flambda-backend: Move float32 back to stable (#2915)
9df24dd 
* Revert "Move float32 back to beta (#2843)"

This reverts commit 4846e6c.

* fix test

* upstream_compatible test

* upstream_compatible simd test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkalinichenko-js dkalinichenko-js dkalinichenko-js approved these changes

Assignees
No one assigned
Labels
build system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ncik-roberts @dkalinichenko-js