Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polling: more tests #2849

Merged
merged 7 commits into from
Oct 29, 2024
Merged

Polling: more tests #2849

merged 7 commits into from
Oct 29, 2024

Conversation

xclerc
Copy link
Contributor

@xclerc xclerc commented Jul 25, 2024

This pull request is adding a couple of
test for the polling insertion phase, and
to do so modifies the way polling errors
are reported.

@xclerc xclerc added cfg backend CI Github Actions CI changes labels Jul 25, 2024
@xclerc xclerc marked this pull request as ready for review July 25, 2024 10:39
mshinwell
mshinwell approved these changes Aug 7, 2024
View reviewed changes
Copy link
Collaborator

@mshinwell mshinwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing to fix, then please merge

ocaml/testsuite/tests/polling/polling.ml Outdated Show resolved Hide resolved
@gretay-js
Copy link
Contributor

@xclerc should we merge this?

@xclerc xclerc merged commit ab89d7f into tweak-polling-test Oct 29, 2024
19 checks passed
@xclerc xclerc deleted the polling-ci branch October 29, 2024 15:59
xclerc added a commit that referenced this pull request Nov 1, 2024
@xclerc
Polling: more tests (#2849)
d09f186
xclerc added a commit that referenced this pull request Nov 1, 2024
@xclerc
Tweak polling test (#2726)
1109817 
* Fix insertion of poll / back edges.

* Tweak polling test.

* CI job to test polling (CFG pipeline) (#2733)

* Polling: more tests (#2849)

* Promote test expectation.

* Promote test expectation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshinwell mshinwell mshinwell approved these changes

Assignees
No one assigned
Labels
backend cfg CI Github Actions CI changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xclerc @gretay-js @mshinwell