Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport upstream #13170 #2912

Merged
merged 3 commits into from
Aug 12, 2024
Merged

Backport upstream #13170 #2912

merged 3 commits into from
Aug 12, 2024

Conversation

ncik-roberts
Copy link
Contributor

Backport ocaml/ocaml#13170.

Testing: the source files build. I can't actually run the test yet.

Review: the first commit fixes merge conflicts in the w53.ml test (cc @mshinwell, as you asked me to do this earlier). The rest of the commits backport #13170.

Copy link
Contributor

@ccasin ccasin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the test reference file is missing, but otherwise looks good.

Base automatically changed from merge-5.2-fix-typecore to merge-5.2 August 12, 2024 16:33
@ncik-roberts ncik-roberts force-pushed the merge-5.2-backport-13170 branch from 315c498 to 5e7692e Compare August 12, 2024 20:14
@ncik-roberts ncik-roberts merged commit 0bc0cd6 into merge-5.2 Aug 12, 2024
1 of 18 checks passed
@ncik-roberts ncik-roberts deleted the merge-5.2-backport-13170 branch August 12, 2024 20:15
lukemaurer pushed a commit to lukemaurer/flambda-backend that referenced this pull request Oct 23, 2024
* Fix conflicts in w53 test

* backport upstream #13170

* Add compilers reference file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants