Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix printing of user-defined option type used for optional arguments #3135

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

riaqn
Copy link
Contributor

@riaqn riaqn commented Oct 11, 2024

What the titles says. Please review by commits.

@riaqn riaqn requested a review from lpw25 October 11, 2024 14:55
Copy link
Collaborator

@lpw25 lpw25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure when this started being necessary, but this seems more robust and I think it should work fine.

ocaml/typing/printtyp.ml Show resolved Hide resolved
@riaqn riaqn merged commit 5c6a171 into main Oct 16, 2024
16 checks passed
@riaqn riaqn deleted the printtyp-opt-args branch October 16, 2024 08:58
lukemaurer pushed a commit to lukemaurer/flambda-backend that referenced this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants