Improve comments of uniqueness analysis #3197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anfelor
reviewed
Oct 29, 2024
Merged
riaqn
force-pushed
the
better-unique-comments
branch
from
261e22e to
d081a14
Compare
|
We had an offline discussion. I've revised according to the discussion. @anfelor Can you take another look? BTW we agreed that the usage ordering should be from the view of the UA (i.e., you can relax [Aliased] to [Unique]), but I just realized that most comments are more sensible if talking from the type checker's view, and it would just be confusing to introduce UA's ordering and explain why they are opposite. So in the end, I only use the type checker's ordering (you can relax [Unique] to [Aliased]) without any of the UA's ordering. |
riaqn
force-pushed
the
better-unique-comments
branch
from
d081a14 to
ae20d0f
Compare
anfelor
approved these changes
Dec 6, 2024
riaqn
force-pushed
the
better-unique-comments
branch
from
ae20d0f to
5fb9a4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the comments on uniqueness analysis.
Review: @anfelor