-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supports mode annotation on function body #3327
Conversation
Parser Change ChecklistThis PR modifies the parser. Please check that the following tests are updated:
This test should have examples of every new bit of syntax you are adding. Feel free to just check the box if your PR does not actually change the syntax (because it is refactoring the parser, say). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Liam to do further review since I realized I don't have context on typing/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I did not review the changes in parser.mly
under the premise that @tdelvecchio-jsc already reviewed it.)
I'd like to see a test that shows that this allows a stronger interface to be inferred for a ml
-only module.
a3c6677
to
8fd10b9
Compare
This PR adds the support for the following syntax:
Please review by commits.
Please do not merge until I finish the internal migration for the new parsetree.