Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear ephemerons which expire in a minor GC #3495

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Clear ephemerons which expire in a minor GC #3495

wants to merge 2 commits into from
+198 −42

Conversation

NickBarnes
Copy link
Contributor

This is a rework of @stedolan's work in #3402, to address style points raised in review there, and also fix the hilarious bug found upstream (see ocaml/ocaml#13643 (comment)).

@NickBarnes
Copy link
Contributor Author

The CI failure of this PR is somewhat mysterious, and seems to result from recent changes to CI rather than anything in the PR itself.

@NickBarnes
Copy link
Contributor Author

More on the CI failure: lib-runtime-events/test_fork.ml is sometimes creating a core file but also succeeding. That core file is then confusing the CI run. Presumably the core file is made by the child process after it makes the EV_FORK_CHILD event. Hard to reproduce and probably unrelated to this actual PR, so we're disregarding it.

@NickBarnes NickBarnes force-pushed the nbarnes-minor-ephemerons branch from a0d2919 to 66a8f32 Compare February 5, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NickBarnes @stedolan @mshinwell