Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix under-reporting of custom block sizes in runtime4 Gc.Memprof #3520

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Fix under-reporting of custom block sizes in runtime4 Gc.Memprof #3520

merged 1 commit into from
Jan 28, 2025

Conversation

stedolan
Copy link
Contributor

The custom block sizes should be rounded up to words, not down.

(Already correct in runtime5)

@stedolan
Fix under-reporting of custom block sizes in runtime4 Gc.Memprof
664e457 
The custom block sizes should be rounded *up* to words, not down.

(Already correct in runtime5)
NickBarnes
NickBarnes approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@NickBarnes NickBarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously correct. Maybe Wsize_bsize should round up automatically (or have a better name).

@NickBarnes NickBarnes merged commit 29a3c72 into ocaml-flambda:main Jan 28, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickBarnes NickBarnes NickBarnes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stedolan @NickBarnes