Ensure that pool owners are correctly set on pool adoption #3521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickBarnes
force-pushed
the
pool_owner_fix
branch
from
4561a26 to
61ab797
Compare
(Plus a new compaction test for the failure triggered by getting this wrong)
NickBarnes
force-pushed
the
pool_owner_fix
branch
from
61ab797 to
0289a94
Compare
stedolan
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shared heap pools have an "owner" field referring to the
caml_domain_statewhich owns them. It'sNULLfor free pools. We weren't setting the owner correctly sometimes when acquiring a pool from the global free list.(This bug was harmless on the current main sources but caused a hard-to-fix bug in the new compaction #3179 for some workloads such as the test also included here).
This is @stedolan's fix.