Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For buffered serialization into a
flow
, at the moment there is onlyBuf_write.with_flow
, so those serializers are expected to always run wrapped within a single function.This PR introduces
Buf_write.of_flow
which allows a serializer to outlive its invocation, but instead being restricted by a surroundingSwitch
, as usual. Also, proper closing of the write is ensured bySwitch.on_release
in success as well as error cases.. This makesBuf_write
more straight forward to use e.g. in network protocols, which otherwise need unfortunate workarounds like this one:Moreover,
Buf_write.with_flow
is simplified by just callingBuf_write.of_flow
within a localSwitch
.