Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I quickly played around with adding kqueue support to iomux, this PR definitely shouldn't be merged but just wanted to make people aware of the experiment :)) (if it is noisy please close).
The current API uses the same
buffer
that can be shared betweenpoll
andppoll
as they're pretty similar. This is nice becauseset_index
and can be used and then either ofpoll
orppoll
can be called. With kqueue you have to maintain some event lists instead and then you either have to make a choice or maintain both bits of state so that this can be preserved. Because I was quickly experimenting I didn't maintain the state and hence I changed some of the tests. This is probably not the way forward.