feature: clear terminal in watch mode by default

Fix #5216 Signed-off-by: Rudi Grinberg <[email protected]> ps-id: 00DAEB6C-D14B-43AC-A393-AF77ACDD9EC4
ocaml · Apr 30, 2022 · 4043f59 · 4043f59
1 parent 35a0fcf
commit 4043f59
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -1,6 +1,9 @@
 3.2.0 (Unreleased)
 -----------------
 
+- Watch mode now default to clearing the terminal on rebuild(#5636, fixes,
+  #5216, @rgrinberg)
+
 - Add a fmt command as a shortcut of `dune build @fmt --auto-promote` (#5574,
   @tmattio)
 

diff --git a/src/dune_config/dune_config.ml b/src/dune_config/dune_config.ml
@@ -256,7 +256,7 @@ let equal a b = Poly.equal a b
 let default =
   { display = { verbosity = Quiet; status_line = not Config.inside_dune }
   ; concurrency = (if Config.inside_dune then Fixed 1 else Auto)
-  ; terminal_persistence = Terminal_persistence.Preserve
+  ; terminal_persistence = Clear_on_rebuild
   ; sandboxing_preference = []
   ; cache_enabled = Disabled
   ; cache_reproducibility_check = Skip

diff --git a/test/expect-tests/dune_config/dune_config_test.ml b/test/expect-tests/dune_config/dune_config_test.ml
@@ -22,7 +22,7 @@ let%expect_test "cache-check-probability 0.1" =
     {|
     { display = { status_line = false; verbosity = Quiet }
     ; concurrency = Fixed 1
-    ; terminal_persistence = Preserve
+    ; terminal_persistence = Clear_on_rebuild
     ; sandboxing_preference = []
     ; cache_enabled = Disabled
     ; cache_reproducibility_check = Check_with_probability 0.1
@@ -38,7 +38,7 @@ let%expect_test "cache-storage-mode copy" =
     {|
     { display = { status_line = false; verbosity = Quiet }
     ; concurrency = Fixed 1
-    ; terminal_persistence = Preserve
+    ; terminal_persistence = Clear_on_rebuild
     ; sandboxing_preference = []
     ; cache_enabled = Disabled
     ; cache_reproducibility_check = Skip
@@ -54,7 +54,7 @@ let%expect_test "cache-storage-mode hardlink" =
     {|
     { display = { status_line = false; verbosity = Quiet }
     ; concurrency = Fixed 1
-    ; terminal_persistence = Preserve
+    ; terminal_persistence = Clear_on_rebuild
     ; sandboxing_preference = []
     ; cache_enabled = Disabled
     ; cache_reproducibility_check = Skip