fix: do not hide lib interface module (#6549)

Signed-off-by: Rudi Grinberg <[email protected]> ps-id: f6931bc9-6cd8-4172-a865-fce524052fb7 Co-authored-by: Etienne Millon <[email protected]>
ocaml · Nov 24, 2022 · 96fe384 · 96fe384
1 parent 0a77fb9
commit 96fe384
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -1,6 +1,8 @@
 Unreleased
 ----------
 
+- Do not shadow library interface modules (#6549, fixes #6545, @rgrinberg)
+
 - Move `$ dune ocaml-merlin -dump-config=$dir` to `$ dune ocaml merlin
   dump-config $dir`. (#6547, @rgrinberg)
 

diff --git a/src/dune_rules/module_compilation.ml b/src/dune_rules/module_compilation.ml
@@ -407,7 +407,10 @@ module Alias_module = struct
              { local_name; obj_name })
     in
     let shadowed =
-      if Dune_project.dune_version project < (3, 5) then []
+      if
+        Dune_project.dune_version project < (3, 5)
+        || Modules.lib_interface modules = None
+      then []
       else
         match Modules.alias_module modules with
         | None -> []

diff --git a/test/blackbox-tests/test-cases/alias-module-generated.t b/test/blackbox-tests/test-cases/alias-module-generated.t
@@ -17,9 +17,6 @@ wrap module is generated by dune.
 
   (** @canonical Foo.Bar *)
   module Bar = Foo__Bar
-
-  module Foo = struct end
-  [@@deprecated "this module is shadowed"]
 
 The final `Foo` module should not be marked as deprecated/shadowed, since it
 does not shadow any module.