Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misinterpretation of META's exists_if directive by dune. #10563

Closed
dbuenzli opened this issue May 23, 2024 · 1 comment · Fixed by #10564 or ocaml/opam-repository#25931
Closed

Misinterpretation of META's exists_if directive by dune. #10563

dbuenzli opened this issue May 23, 2024 · 1 comment · Fixed by #10564 or ocaml/opam-repository#25931

Comments

@dbuenzli
Copy link

dbuenzli commented May 23, 2024

It seems that dune misinterprets the semantics of META's exists_if field.

The package should exist if any of the file is exists (see this page), not all of them. Basically this line should be turned into an List.exists.

This hides the latest cmdliner (1.3.0) release on 32-bit platforms, see ocaml/opam-repository#25924

@dbuenzli dbuenzli changed the title Misintepretation of META's exist_if directive by dune. Misinterpretation of META's exist_if directive by dune. May 23, 2024
@dbuenzli dbuenzli changed the title Misinterpretation of META's exist_if directive by dune. Misinterpretation of META's exists_if directive by dune. May 23, 2024
@nojb
Copy link
Collaborator

nojb commented May 23, 2024

Good detective work; fix as suggested in #10564.

emillon added a commit to emillon/opam-repository that referenced this issue May 24, 2024
CHANGES:

### Fixed

- Fix interpretation of `exists_if` predicate in `META` files of installed
  libraries containing more than one element. (ocaml/dune#10564, fixes ocaml/dune#10563, @dbuenzli,
  @nojb)

- Fix TSAN warning in wait4 stubs (ocaml/dune#10554, fixes ocaml/dune#10553, @emillon)
avsm pushed a commit to avsm/opam-repository that referenced this issue Sep 5, 2024
CHANGES:

### Fixed

- Fix interpretation of `exists_if` predicate in `META` files of installed
  libraries containing more than one element. (ocaml/dune#10564, fixes ocaml/dune#10563, @dbuenzli,
  @nojb)

- Fix TSAN warning in wait4 stubs (ocaml/dune#10554, fixes ocaml/dune#10553, @emillon)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants