-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promote tests are failing on Travis/OSX #456
Comments
I found the issue: we are hashing files to detect contents changes. To avoid rehashing files all the times, we check the mtime first. However, on OSX mtime is not precise enough. As a result |
ghost
pushed a commit
that referenced
this issue
Jan 29, 2018
Previously we were only using mtime but it's not precise on OSX. Fix #456
ghost
pushed a commit
that referenced
this issue
Jan 30, 2018
Previously we were only using mtime but it's not precise on OSX. Fix #456
ghost
pushed a commit
that referenced
this issue
Jan 30, 2018
Previously we were only using mtime but it's not precise on OSX. Fix #456
ghost
pushed a commit
that referenced
this issue
Jan 30, 2018
Previously we were only using mtime but it's not precise on OSX. Fix #456
ghost
pushed a commit
that referenced
this issue
Jan 30, 2018
This is to avoid problems with incremental compilation on OSX. Fix #456
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Here's an excerpt:
https://travis-ci.org/ocaml/dune/jobs/334103036
cc @diml @dra27 because I can't reproduce on my own Mac.
The text was updated successfully, but these errors were encountered: