Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote tests are failing on Travis/OSX #456

Closed
rgrinberg opened this issue Jan 27, 2018 · 1 comment
Closed

Promote tests are failing on Travis/OSX #456

rgrinberg opened this issue Jan 27, 2018 · 1 comment

Comments

@rgrinberg
Copy link
Member

rgrinberg commented Jan 27, 2018

Here's an excerpt:

        diff (internal) (exit 1)
(cd _build/default && /usr/bin/diff -u test/blackbox-tests/test-cases/promote/run.t test/blackbox-tests/test-cases/promote/run.t.corrected)
--- test/blackbox-tests/test-cases/promote/run.t	2018-01-27 14:23:22.000000000 +0000
+++ test/blackbox-tests/test-cases/promote/run.t.corrected	2018-01-27 14:23:33.000000000 +0000
@@ -12,6 +12,9 @@
   toto
 
   $ $JBUILDER build --root . -j1 --diff-command false @blah
+            sh (internal) (exit 1)
+  (cd _build/default && /bin/sh -c 'false x x.gen')
+  [1]
   $ cat x
   toto
 
@@ -23,5 +26,8 @@
   $ cat x
   toto
   $ $JBUILDER build --root . -j1 --diff-command false @blah
+            sh (internal) (exit 1)
+  (cd _build/default && /bin/sh -c 'false x x.gen')
+  [1]
   $ cat x
   toto
+RESULT=1
+'[' 1 -eq 0 ']'
+exit 1

https://travis-ci.org/ocaml/dune/jobs/334103036

cc @diml @dra27 because I can't reproduce on my own Mac.

@ghost
Copy link

ghost commented Jan 29, 2018

I found the issue: we are hashing files to detect contents changes. To avoid rehashing files all the times, we check the mtime first. However, on OSX mtime is not precise enough. As a result x wasn't copied back from the source tree to the build directory...

ghost pushed a commit that referenced this issue Jan 29, 2018
Previously we were only using mtime but it's not precise on OSX.

Fix #456
ghost pushed a commit that referenced this issue Jan 30, 2018
Previously we were only using mtime but it's not precise on OSX.

Fix #456
ghost pushed a commit that referenced this issue Jan 30, 2018
Previously we were only using mtime but it's not precise on OSX.

Fix #456
ghost pushed a commit that referenced this issue Jan 30, 2018
Previously we were only using mtime but it's not precise on OSX.

Fix #456
ghost pushed a commit that referenced this issue Jan 30, 2018
This is to avoid problems with incremental compilation on OSX.

Fix #456
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant