Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty missing dependencies while a (test) package is missing #644

Closed
xclerc opened this issue Mar 20, 2018 · 3 comments
Closed

Empty missing dependencies while a (test) package is missing #644

xclerc opened this issue Mar 20, 2018 · 3 comments
Labels

Comments

@xclerc
Copy link
Collaborator

xclerc commented Mar 20, 2018

If one tries to set up inline tests with a jbuild file akin to the one below
while the inline_test package is not installed, the following message is
output:

Error: Library "ppx_inline_test" not found.
Hint: try: jbuilder external-lib-deps --missing @runtest

However, the execution of the suggested command line prints nothing.


(library
 ((name lib)
  (inline_tests)
  (preprocess (pps (ppx_inline_test)))))
@rgrinberg rgrinberg added the bug label Mar 22, 2018
@trefis
Copy link
Collaborator

trefis commented Mar 23, 2018

I'm a bit surprised that this issue popped up again (cf #485 ).
Is there no way to add a regression test for this?

@ghost
Copy link

ghost commented Mar 23, 2018

There is a test but it's only testing the libraries field, there might be another issue for the preprocess field.

ghost pushed a commit that referenced this issue Mar 27, 2018
@ghost
Copy link

ghost commented Mar 27, 2018

I found the issue. It's a bit annoying to fix and the code that implement external-lib-deps already requires to be careful when writing the rules. I have an idea to catch external library dependencies more systematically without having to think about it while the rules, I'm going to try that.

ghost pushed a commit that referenced this issue Mar 29, 2018
ghost pushed a commit that referenced this issue Mar 31, 2018
rgrinberg pushed a commit that referenced this issue Apr 3, 2018
rgrinberg pushed a commit that referenced this issue Apr 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants