Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test apparatus for MSVC #6535

Closed
jonahbeckford opened this issue Nov 21, 2022 · 1 comment
Closed

Test apparatus for MSVC #6535

jonahbeckford opened this issue Nov 21, 2022 · 1 comment
Assignees
Labels

Comments

@jonahbeckford
Copy link
Collaborator

This is a follow-up to #6517. dune is kinda important, so I'd like to see MSVC tested! It is fine to assign this bug report to me, and at some point (not soon, sorry) I can submit a PR to get it working with dkml-workflows. Be aware that I use generative templates (that is, I use dune promote to generate and upgrade many support files) to create the GitHub Actions and desktop testing workflows.

cc: @rgrinberg @nojb

jonahbeckford added a commit to jonahbeckford/dune that referenced this issue Nov 21, 2022
jonahbeckford added a commit to jonahbeckford/dune that referenced this issue Nov 21, 2022
jonahbeckford added a commit to jonahbeckford/dune that referenced this issue Nov 21, 2022
jonahbeckford added a commit to jonahbeckford/dune that referenced this issue Nov 21, 2022
jonahbeckford added a commit to jonahbeckford/dune that referenced this issue Nov 21, 2022
jonahbeckford added a commit to jonahbeckford/dune that referenced this issue Nov 21, 2022
jonahbeckford added a commit to jonahbeckford/dune that referenced this issue Nov 21, 2022
jonahbeckford added a commit to jonahbeckford/dune that referenced this issue Nov 21, 2022
jonahbeckford added a commit to jonahbeckford/dune that referenced this issue Nov 21, 2022
jonahbeckford added a commit to jonahbeckford/dune that referenced this issue Nov 22, 2022
jonahbeckford added a commit to jonahbeckford/dune that referenced this issue Nov 22, 2022
jonahbeckford added a commit to jonahbeckford/dune that referenced this issue Nov 22, 2022
jonahbeckford added a commit to jonahbeckford/dune that referenced this issue Nov 22, 2022
jonahbeckford added a commit to jonahbeckford/dune that referenced this issue Nov 22, 2022
Implements ocaml#6535

Signed-off-by: Jonah Beckford <[email protected]>
jonahbeckford added a commit to jonahbeckford/dune that referenced this issue Nov 23, 2022
Implements ocaml#6535

Signed-off-by: Jonah Beckford <[email protected]>
@jonahbeckford
Copy link
Collaborator Author

This was closed with #6540

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants