.merlin has no ppx when several libraries are defined #657
Comments
facebook-github-bot
pushed a commit
to facebook/infer
that referenced
this issue
Mar 27, 2018
Summary: Partial revert of a216446 / D7381857 due to an issue introduced in 1.0+beta19 that prevents jbuilder from generating the correct .merlin (ocaml/dune#657). Reviewed By: mbouaziz Differential Revision: D7414970 fbshipit-source-id: 10561e9
|
Indeed, thanks for finding the cause of the bug. I added a test case and a fix in #658. |
ghost
closed this as This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is only when the libraries define
(preprocess (pps ...))directives, but happens even when they have the same directives, unlike #230.I think this is because
Jbuild.Preprocess.ppsincludes location information (since 138c920) andMerlin.merge_twocompares these objects for equality using=. This comparison will almost always be false because two directives will have different source locations in the jbuild file.The text was updated successfully, but these errors were encountered: