Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dune ocaml top-module crashes when given an absolute path #7370

Closed
Alizter opened this issue Mar 21, 2023 · 0 comments · Fixed by #8249
Closed

dune ocaml top-module crashes when given an absolute path #7370

Alizter opened this issue Mar 21, 2023 · 0 comments · Fixed by #8249
Labels
bug
Milestone
3.14.0

Comments

@Alizter
Copy link
Collaborator

Alizter commented Mar 21, 2023

Reproduction case in #7369.
@Alizter Alizter added the bug label Mar 21, 2023
This was referenced Jul 18, 2023
Merged
Merged
@rgrinberg rgrinberg added this to the 3.14.0 milestone Jan 23, 2024
@emillon emillon mentioned this issue Feb 5, 2024
Merged
emillon added a commit to emillon/opam-repository that referenced this issue Feb 5, 2024
@emillon
[new release] dune (15 packages) (3.13.1)
4d0205d 
CHANGES:

- Fix performance regression for incremental builds (ocaml/dune#9769, fixes ocaml/dune#9738,
  @rgrinberg)

- Fix `dune ocaml top-module` to correctly handle absolute paths. (ocaml/dune#8249, fixes
  ocaml/dune#7370, @Alizter)

- subst: ignore broken symlinks when looking at source files (ocaml/dune#9810, fixes
  ocaml/dune#9593, @emillon)

- subst: do not fail on 32-bit systems when large files are encountered. Just
  log a warning in this case. (ocaml/dune#9811, fixes ocaml/dune#9538, @emillon)

- boot: sort directory entries in readdir. This makes the dune binary
  reproducible in terms of filesystem order. (ocaml/dune#9861, fixes ocaml/dune#9794, @emillon)
nberth pushed a commit to nberth/opam-repository that referenced this issue Jun 18, 2024
@emillon @nberth
[new release] dune (15 packages) (3.13.1)
cc606c9 
CHANGES:

- Fix performance regression for incremental builds (ocaml/dune#9769, fixes ocaml/dune#9738,
  @rgrinberg)

- Fix `dune ocaml top-module` to correctly handle absolute paths. (ocaml/dune#8249, fixes
  ocaml/dune#7370, @Alizter)

- subst: ignore broken symlinks when looking at source files (ocaml/dune#9810, fixes
  ocaml/dune#9593, @emillon)

- subst: do not fail on 32-bit systems when large files are encountered. Just
  log a warning in this case. (ocaml/dune#9811, fixes ocaml/dune#9538, @emillon)

- boot: sort directory entries in readdir. This makes the dune binary
  reproducible in terms of filesystem order. (ocaml/dune#9861, fixes ocaml/dune#9794, @emillon)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
3.14.0
Development

Successfully merging a pull request may close this issue.

fix: correctly handle absolute paths in dune ocaml top-module Alizter/dune
2 participants
@rgrinberg @Alizter