test: add tests for library name collisions #10170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Javier Chávarri <[email protected]>
|
Thanks. Could you move the lib-collision-* tests to a single folder? That would make it easier to run all of them. |
Signed-off-by: Javier Chávarri <[email protected]>
anmonteiro
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #9839, I ended up running into several scenarios that can occur when two libraries have the same name, and the existing test infrastructure was not enough for my needs (there are only some coq tests that cover this functionality). I am extracting all the tests into a separate PR so it gets easier to see how the behavior changes in that PR, vs the current behavior in
main.